Fix CStunSocket::SetNonBlocking to accept false as param (benign bug)

5e288699 · John Selbie · 7c2c0528 · 5e288699 · 5e288699
Commit 5e288699 authored May 29, 2012 by John Selbie
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 3 deletions

common.inc common.inc +1 -1

networkutils/stunsocket.cpp networkutils/stunsocket.cpp +9 -2

No files found.
--- a/common.inc
+++ b/common.inc
-# BOOST_INCLUDE := -I/home/jselbie/boost_1_48_0
+BOOST_INCLUDE := -I/home/jselbie/boost_1_48_0
 # OPENSSL_INCLUDE := -I/home/jselbie/lib/openssl

 DEFINES := -DNDEBUG

--- a/networkutils/stunsocket.cpp
+++ b/networkutils/stunsocket.cpp
@@ -203,8 +203,15 @@ HRESULT CStunSocket::SetNonBlocking(bool fEnable)
    flags = ::fcntl(_sock, F_GETFL, 0);
    
    ChkIf(flags == -1, ERRNOHR);
-    
-    flags |= O_NONBLOCK;
+
+    if (fEnable)
+    {    
+        flags |= O_NONBLOCK;
+    }
+    else
+    {
+        flags &= ~(O_NONBLOCK);
+    }
    
    result = fcntl(_sock , F_SETFL , flags);